[tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc
is used)
-------------------------------------------------+-------------------------
 Reporter:  icanhasaccount                       |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  review-group-31,                     |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-    |
  in-20180711                                    |
Parent ID:                                       |         Points:  .2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Hello71):

 Replying to [comment:35 nickm]:
 > Let's try to get this unstuck, by disentangling the various options.
 >
 > I've made a branch `remove_openbsd_malloc` that ports icanhasaccount's
 removal code to master if we decide to do that.  PR at
 https://github.com/torproject/tor/pull/224 . Not my preferred approach.
 >
 > And I've made a branch called `with_malloc` that ports the parts of
 Hello71's patch that I agree with to master: it adds --with-malloc=,
 doesn't change our default, doesn't break old configure options, and keeps
 openbsd malloc as an option.  Works for me, but probably needs more review
 and testing. PR at https://github.com/torproject/tor/pull/225 .
 >
 > The above two branches apply to master only and are mutually exclusive,
 though we could probably combine them into one.
 >
 > For backport purposes, I have a branch `fix_nonstandard_malloc_029` that
 only does the minimum needed to fix the originally supported issue. PR at
 https://github.com/torproject/tor/pull/226 . Works for me.

 Thanks for fixing my patch and giving credit, but I'd appreciate it if you
 called me Alex Xu in changelog, or at least not put my nick in quotation
 marks (looks like scare quotes to me). Also, I think you put too many twos
 in the change file.

 On the patch itself, I did actually test what happens when Rust is linked
 in: it works fine. I think Rust probably uses the system allocator on
 Linux, so replacing the malloc this way in glibc should also replace the
 Rust allocator and everything works fine.

 Also, I'm not sure it's a good idea to leave all of these options in if
 nobody is actually going to test them (as shown by openbsd malloc being
 broken by all this time and nobody really caring that much to fix it).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20424#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online