[tor-bugs] #25055 [Core Tor/Tor]: string_is_valid_hostname() returns true for IPv4 addresses

[Tor Bug Tracker & Wiki]

#25055: string_is_valid_hostname() returns true for IPv4 addresses
-------------------------------+------------------------------------
 Reporter:  teor               |          Owner:  (none)
     Type:  defect             |         Status:  new
 Priority:  Medium             |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  IPv6 IPv4 tor-dns  |  Actual Points:
Parent ID:                     |         Points:  1
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------------

Comment (by arma):

 It is meant to return true for everything that exits will let you (try to)
 connect to.

 Maybe that means changing the word "hostname" to a word that doesn't make
 some people think it can't be an IP address.

 It also sounds like allowing ipv6 addresses is the right thing to do.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25055#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online