[tor-bugs] #25055 [Core Tor/Tor]: string_is_valid_hostname() returns true for IPv4 addresses

[Tor Bug Tracker & Wiki]

#25055: string_is_valid_hostname() returns true for IPv4 addresses
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  IPv6 IPv4 tor-dns
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 If it is meant to return true for all IP addresses, it should return true
 for IPv6 as well.
 If it's meant to return true just for hostnames, it should reject IPv4
 addresses.

     a valid host name can never have the dotted-decimal form #.#.#.#,
 since at least the highest-level component label will be alphabetic

 https://tools.ietf.org/html/rfc1123#page-13

 Then we should check every use of this function, to make sure it is being
 used the right way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25055>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online