[tor-bugs] #24911 [Core Tor/Tor]: Remove the known digest check from channel_check_for_duplicates()

[Tor Bug Tracker & Wiki]

#24911: Remove the known digest check from channel_check_for_duplicates()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, redundant, technical-debt  |  Actual Points:
Parent ID:  #23423                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 I think this would help - should we even be storing v1 and v2 client
 certificate fingerprints anyway?

 But there are still two separate questions we can ask, and we should keep
 them separate:
 * channel_is_client(): does the remote end act like a client (use v1 or
 v2, or not authenticate and use v3 or v4)
 * …is_known_relay(): was the remote end authenticated and in a recent
 consensus?

 There is a small gap between these two cases, filled with unpublished
 relays.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24911#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online