[tor-bugs] #24911 [Core Tor/Tor]: Remove the known digest check from channel_check_for_duplicates()

[Tor Bug Tracker & Wiki]

#24911: Remove the known digest check from channel_check_for_duplicates()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, redundant, technical-debt  |  Actual Points:
Parent ID:  #23423                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [comment:2 teor]:
 > Ok, let's make channel_add_to_digest_map check for channel_is_client().

 Actually, for whatever version we decide to backport the more-accurate
 channel_is_client() to, I think we would be wise to work towards having an
 invariant where, when channel_is_client is true, conn->identity_digest is
 zero. I think we're not too far away from having that be true now, and it
 would sure simplify things for us rather than forcing us to sprinkle in
 tiny confusion exception clauses everywhere.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24911#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online