[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

[Tor Bug Tracker & Wiki]

#24898: We have two conflicting notions of channel_is_client()
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, 032-backport,             |  Actual Points:
  031-backport, 030-backport-maybe-with-21406,   |
  029-backport-maybe-with-21406                  |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:   =>
     tor-relay, 032-backport, 031-backport, 030-backport-maybe-with-21406,
     029-backport-maybe-with-21406
 * reviewer:   => teor
 * points:   => 0.5
 * status:  new => merge_ready
 * version:   => Tor: 0.3.1.1-alpha


Comment:

 This works fine for me in the latest chutney, that comment it outdated.

 But please don't remove these lines, they are used by rep_hist:
 {{{
   if (connection_or_digest_is_known_relay(chan->identity_digest)) {
 rep_hist_note_circuit_handshake_requested(create_cell->handshake_type);
 }}}

 I restored this code in my branch bug24898 on
 https://github.com/teor2345/tor.git

 Now we just have to decide how far to backport it.
 If we want it to go to 0.3.0 or 0.2.9, we need to backport #21406 as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online