[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

[Tor Bug Tracker & Wiki]

#24898: We have two conflicting notions of channel_is_client()
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, 032-backport,             |  Actual Points:
  031-backport, 030-backport-maybe-with-21406,   |
  029-backport-maybe-with-21406                  |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Comment written in parallel to teor's above comment:

 I pushed a {{{bug24898}}} branch that I think fixes everything.

 It's on master though, and we might want to backport this. I'm not sure
 how far back to backport it -- we could go back to maint-0.3.1 pretty
 easily (there's a conflict but it's just because of a comment), but going
 back to 0.2.9 would be quite tricky because #21406 went into 0.3.1.

 The question of whether to backport more depends on how much we want these
 fixes in 0.2.9 -- this one is a cornerstone of some of the DoS mitigations
 that might come next.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online