[tor-bugs] #22926 [Core Tor/Tor]: The Tor compression code can call functions that are NULL

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 6 04:12:26 UTC 2018


#22926: The Tor compression code can call functions that are NULL
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  ahf
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  assigned => needs_review


Comment:

 There's a potential patch for parts of this issue in
 https://gitlab.com/ahf/tor/merge_requests/22

 Note that the patch does the `NULL` function checks for the zlib backend:
 we might want to consider adding a `tor_assert(0)` in the pathological
 case there since zlib is still required to be able to use Tor.

 I'm marking this `needs_review`, but these patches does not fix everything
 Teor mentioned above. We still need to add checks to `configure` and
 document the weak linking issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22926#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list