[tor-bugs] #22926 [Core Tor/Tor]: The Tor compression code can call functions that are NULL

[Tor Bug Tracker & Wiki]

#22926: The Tor compression code can call functions that are NULL
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  ahf
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:9 nickm]:
 > Have we advanced our thinking any here?  It still seems to me that
 "don't do that then" is the right solution.

 We have decided to support running Tor as a library.
 Therefore, we will see more linking issues in future.

 I suggest we:
 * document this weak linking issue
 * check for NULL pointers to functions in optional libraries at configure
 time
 * check for NULL pointers to functions in optional libraries at runtime

 Otherwise, people will be surprised the first time their tor tries to use
 the compression code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22926#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online