[tor-bugs] #26972 [Core Tor/Tor]: Create make target to ensure that all Rust files have been formatted with rustfmt (was: Create CI task to ensure that all Rust files have been formatted with rustfmt)

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Aug 16 09:06:49 UTC 2018


#26972: Create make target to ensure that all Rust files have been formatted with
rustfmt
--------------------------+------------------------------------
 Reporter:  chelseakomlo  |          Owner:  teor
     Type:  enhancement   |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:  #24629        |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * keywords:  rust, 036-proposed => rust
 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:19 cypherpunks3]:
 > Replying to [comment:14 teor]:
 >
 > I created a new branch 'rustfmt-notravis' at
 https://gitgud.io/onionk/tor.git with the only new changes being the
 removal of the Travis commit, and fixing a typo in CodingStandardsRust.md.

 Thanks for making these changes.

 There's a typo in CodingStandardsRust.md in your 132c7950dc. I did a fixup
 in da6054fe97 in my rustfmt-notravis branch.

 Next time, please add reverts and fixups to the existing commits. If you
 rewrite the whole branch, reviewers have to review it all again. (Or diff
 the diffs of each commit.)

 Replying to [comment:20 teor]:
 > Please open a new ticket in 0.3.6 with a new branch containing the
 travis commit, so we remember to merge it when rustfmt 0.99.1 becomes
 stable.

 I opened #27161 for follow-up.

 Please merge rustfmt-notravis in my https://github.com/teor2345/tor.git
 The pull request is https://github.com/torproject/tor/pull/275

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26972#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list