[tor-bugs] #27161 [Core Tor/Tor]: Add make check-rustfmt to make check

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Aug 16 09:01:30 UTC 2018


#27161: Add make check-rustfmt to make check
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  teor
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.6.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  rust, rustfmt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In #26972, we discovered that stable and nightly rustfmt disagree about
 the formatting of some of Tor's Rust code. Beta currently follows nightly.

 On 13 September, the current beta branch will become stable, and the
 formatting differences should go away. (Rust releases happen every 6
 weeks, and the last one was on 2 August 2018: https://github.com/rust-
 lang/rust/blob/master/RELEASES.md .)

 Here's what we need to do:
 * cherry-pick the final commit on the branch 'rustfmt-travis' from
 ​​https://gitgud.io/onionk/tor.git or https://github.com/teor2345/tor.git
 * run rustfmt on any Rust code added since #26972, and commit the results
 * make sure "make check" passes with Rust stable, beta, and nightly
 * merge the changes

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27161>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list