[tor-bugs] #25679 [Core Tor/Tor]: Default for TOR_RUST_DEPENDENCIES is wrong?

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 5 02:39:06 UTC 2018


#25679: Default for TOR_RUST_DEPENDENCIES is wrong?
---------------------------------------------+-----------------------------
 Reporter:  nickm                            |          Owner:  nickm
     Type:  defect                           |         Status:  merge_ready
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.3.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:  catalyst                         |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by catalyst):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:10 Hello71]:
 > either `pwd` works, and just use it, or it doesn't work, and we need to
 pull in a real realpath. in this case, it should work fine, so just use
 `pwd`.
 Good point.  If cargo doesn't need parent directories to be "physical",
 then maybe it's not important and plain `pwd` will do.

 We could also leave cleaning up of `ERRORED` to another ticket that isn't
 a bugfix; I don't feel too strongly either way.  So merging this as-is for
 0.3.3 is fine with me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25679#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list