[tor-bugs] #25679 [Core Tor/Tor]: Default for TOR_RUST_DEPENDENCIES is wrong?

[Tor Bug Tracker & Wiki]

#25679: Default for TOR_RUST_DEPENDENCIES is wrong?
---------------------------------------------+-----------------------------
 Reporter:  nickm                            |          Owner:  nickm
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.3.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:  catalyst                         |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by Hello71):

 Replying to [comment:9 catalyst]:
 > * maybe `pwd` should be `pwd -P || pwd`, because bash will retain
 symbolic link path components by default unless `set -o physical` is in
 effect. (The `|| pwd` is in case we're running on a shell that's too old
 to support `pwd -P`.)

 either `pwd` works, and just use it, or it doesn't work, and we need to
 pull in a real realpath. in this case, it should work fine, so just use
 `pwd`.

 > Probably not for a bugfix (maybe a separate ticket):
 > * using `dnl` for comments prevents them from appearing in the generated
 configure script; maybe these should be `#` comments instead. (I think
 it's OK to match surrounding style for now.)

 doesn't really matter, configure scripts are utterly unreadable anyways.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25679#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online