[tor-bugs] #23653 [Core Tor/Tor]: When accessing onion service with no fetchable descriptor, Tor sits around until timeout rather than hanging up

[Tor Bug Tracker & Wiki]

#23653: When accessing onion service with no fetchable descriptor, Tor sits around
until timeout rather than hanging up
----------------------------------+------------------------------------
 Reporter:  arma                  |          Owner:  asn
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  regression backport?  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:  asn                   |        Sponsor:
----------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review
 * reviewer:  dgoulet => asn


Comment:

 Ok some changes happened. I took over the branch as discussed and
 implemented a way to not trigger a new fetch request if we already have
 one pending for a given service.

 So, if we launch 7 SOCKS requests, the first one will fetch then the 6
 others will wait patiently that either the descriptor arrives or the
 fetches fail and they are all closed after.

 See branch: `bug23653_032_01`

 This does NOT implement the above for v2, only v3 for now. If we are
 satisfied with this, we should fix v2 for an improved user experience.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23653#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online