[tor-bugs] #23653 [Core Tor/Tor]: When accessing onion service with no fetchable descriptor, Tor sits around until timeout rather than hanging up

[Tor Bug Tracker & Wiki]

#23653: When accessing onion service with no fetchable descriptor, Tor sits around
until timeout rather than hanging up
----------------------------------+------------------------------------
 Reporter:  arma                  |          Owner:  asn
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  regression backport?  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:  asn                   |        Sponsor:
----------------------------------+------------------------------------

Comment (by asn):

 I think this approach makes sense for v3.

 I pushed my own `bug23653_032_01` with an added fixup which does:
 - Fixes a comment typo.
 - Renames `close_all_conn_wait_desc()` since it was not only doing that
 (it was also cleaning up the HSDir request cache)
 - Made it clean the HSDir request cache even if we don't kill any SOCKS
 connections, because you never know, and we always want to be able to
 retry if the application-layer asks us to.

 BTW the branch now will also fix this for v2, and leave #15937 open. I'm
 fine with this. Maybe we can open a ticket about fixing #15937 for v2
 properly?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23653#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online