[tor-bugs] #23576 [Core Tor/Tor]: Make service_intro_point_new() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23576: Make service_intro_point_new() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 In my commit b4aa8fc3d9 in my branch bug23820_032 (#23820), I ripped out
 IPv6 support in these functions. We'll need to revert that commit, and
 then fix the issues in the function.

 {{{
     Remove buggy IPv6 support from pick_intro_point() and
 service_intro_point_new()

     The previous version of these functions had the following issues:
     * they can't supply both the IPv4 and IPv6 addresses in link
 specifiers,
     * they try to fall back to a 3-hop path when the address for a direct
       connection is unreachable, but this isn't supported by
       launch_rendezvous_point_circuit(), so it fails.
     But we can't fix these things in a bugfix release.

     Instead, always put IPv4 addresses in link specifiers.
     And if a v3 single onion service can't reach any intro points, fail.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23576#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online