[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

[Tor Bug Tracker & Wiki]

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 In my commit 20b0e9e07d in my branch bug23820_032 (#23820), I ripped out
 IPv6 support in hs_get_extend_info_from_lspecs(). We'll need to revert
 that commit, and then fix the issues in the function.

 {{{
 Remove buggy IPv6 support from hs_get_extend_info_from_lspecs()

 The previous version of this function has the following issues:
 * it doesn't choose between IPv4 and IPv6 addresses correctly, and
 * it doesn't fall back to a 3-hop path when the address for a direct
   connection is unreachable.
 But we can't fix these things in a bugfix release.

 Instead, treat IPv6 addresses like any other unrecognised link specifier
 and ignore them. If there is no IPv4 address, return NULL.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online