[tor-bugs] #20887 [Core Tor/Tor]: DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead (was: DIRCACHE_MIN_MB_BANDWIDTH does not stringify on FreeBSD, we should use %d instead)

[Tor Bug Tracker & Wiki]

#20887: DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, intro, refactor,               |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Description changed by arma:

Old description:

> A FreeBSD relay operator reports the message:
> {{{
> [WARN] Being a directory cache (default) with less than
> DIRCACHE_MIN_MB_BANDWIDTH MB of memory is not recommended and may consume
> most of the available resources, consider disabling this functionality by
> setting the DirCache option to 0
> }}}
>
> So we should print the macro value the same way we do every other value,
> using "%d" in the string, and passing it as an argument.
>
> This macro will change name in #20684.

New description:

 A FreeBSD relay operator reports the message:
 {{{
 [WARN] Being a directory cache (default) with less than
 DIRCACHE_MIN_MB_BANDWIDTH MB of memory is not recommended and may consume
 most of the available resources, consider disabling this functionality by
 setting the DirCache option to 0
 }}}

 So we should print the macro value the same way we do every other value,
 using "%d" in the string, and passing it as an argument.

 (This macro changed name in #20684.)

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20887#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online