[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

[Tor Bug Tracker & Wiki]

#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201609                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:19 arthuredelstein]:
 > Replying to [comment:18 gk]:
 > > Okay, I gave v7 another round of testing. On OS X my issue is gone,
 thanks! On Windows it basically remains: The width is good but the height
 is off (I get 730px or 710px).
 > >
 > > Two additional things I'd like to see addressed:
 > >
 > > 1) When maximizing (e.g. by chance) and restarting the window is not
 resized to sane defaults. We should do that, though, at least until
 something for #14429 lands.
 > >
 > > 2) I realized you set `maxWidth` to `1200`. While I generally think it
 could be smart to revisit the decision to cap that value at `1000`, I'd
 like to see this happening in a different ticket. There we could think
 about a new `maxWidth` value based on real data. This would help making
 this move more transparent as well.
 >
 > Here's a new patch that fixes these two issues:
 > https://github.com/arthuredelstein/tor-browser/commit/19459+8
 >
 > I have partially isolated the Windows problem, but unfortunately I'm
 still struggling with it. When I set the gBrowser dimensions, like this:
 > {{{
 > gBrowser.flex = "";
 > gBrowser.height = 1000;
 > }}}
 > the window gets an incorrect extra margin at the bottom (on Windows
 only). I'm in the process of trying to debug to find the cause of the
 extra margin. It looks like it will need a C++ patch to fix this incorrect
 behavior.

 I'm getting closer to a solution. The incorrect extra margin goes away
 when "browser.tabs.drawInTitlebar" is true. It appears that the sizing
 code is somehow not correctly taking the effect of a custom titlebar on
 the overall height into account.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online