[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Sep 5 13:44:23 UTC 2016


#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by gk):

 Just two quick questions regarding the Torbutton patch:

 1) You remove the defense against an OS maximizing the window on start-up
 because it thinks the browser window is taking more space on the screen
 than a particular threshold determines (this happened with Ubuntu Unity on
 displays with low resolution IIRC). Is that a non-issue anymore? (was
 fixed in #7255)

 2) You remove the option to customize the maxWidth and maxHeight. Do you
 think this is not necessary anymore as it was originally used for users
 that ran into corner cases we fixed? If so, I wonder whether it would be
 smart to keep those prefs and checks anyway to allow users a better option
 than to maximize.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list