[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Sep 2 00:31:30 UTC 2016


#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:  tbb-torbutton-conversion, TorBrowserTeam201608 => tbb-
     torbutton-conversion, TorBrowserTeam201609R
 * status:  needs_revision => needs_review


Comment:

 Here's my new version:
 https://github.com/arthuredelstein/tor-browser/commit/19459+5
 I no longer need to use a MutationObserver or anything too nasty.
 Basically I found that if we set the tabBrowser's flex attribute to 0,
 then the XULWindow adjusts its size to conform with whatever tabBrowser
 width and height we specify. Then we can set flex back to 1 when the
 window is first painted.

 And here's the new window sizing code removed from torbutton:
 https://github.com/arthuredelstein/torbutton/commit/19459

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list