[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Nov 11 03:32:09 UTC 2016
#20458: Integration tests should be run locally before committing code changes
--------------------------+------------------------------------
Reporter: chelseakomlo | Owner:
Type: enhancement | Status: new
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: test, doc | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor:
--------------------------+------------------------------------
Comment (by teor):
Replying to [comment:11 chelseakomlo]:
> Replying to [comment:9 teor]:
> > Replying to [comment:8 chelseakomlo]:
> > > * '''Reviewer''' set to ''teor''
> >
> > I'm not sure I'll have time to review this any time soon.
> > I may not be the best person for it, because I am not familiar with
jenkins or docker.
>
> Sure, that's fine. Who would you suggest to review this?
I suggest you split this ticket into a subticket for each set of changes.
* Your changes to the tor documentation could be reviewed by any of the
current developers, or just given straight to nickm.
* Your changes to jenkins and docker are best reviewed by people familiar
with them - I'm not sure who that is, but weasel does admin our jenkins
instances.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list