[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes

[Tor Bug Tracker & Wiki]

#20458: Integration tests should be run locally before committing code changes
--------------------------+------------------------------------
 Reporter:  chelseakomlo  |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  test, doc     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:10 cypherpunks]:
 > As proposed in comment:3 `make check` should be the ''run all tests''
 target because it is the
 [https://www.gnu.org/software/automake/manual/automake.html#Standard-
 Targets standard Makefile target] for running test suites.
 >
 > IMO the other test targets should be able to gracefully handle
 situations where Stem, Chutney or Perl (in the case of check-spaces and
 check-docs) are not available. Currently none of these targets do this and
 just fail by either exiting with exit code 1 or simply running non-
 existing commands (which leads to the same result).

 You could also open another ticket to address this feedback.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online