[tor-bugs] #14334 [Tor]: Bugs when registering guard status in connection_or_connect()

[Tor Bug Tracker & Wiki]

#14334: Bugs when registering guard status in connection_or_connect()
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  asn
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-guard, 027-triaged-1-in,         |        Version:  Tor:
  PostFreeze027                                  |  0.2.7
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:  small
                                                 |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  assigned => needs_review


Comment:

 Please see my branch `bug14334` for a fix here based on comment:7.

 I opted for removing that whole block of code, because it doesn't seem
 useful. `connection_connect()` can fail for various local reasons, which
 have nothing to do with the status of our guard.

 The only problem with this patch would be if there are any platforms where
 `connect()` actually connects to the guard in a blocking manner and then
 immediately returns `-1` if the connection fails. If this is the case,
 then we need a more complex patch where we would distinguish between
 `connection_connect_sockaddr()` failing for local reasons and `connect()`
 failing for remote reasons before we mark the guard as down.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14334#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online