[tor-bugs] #17901 [Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

Mon Mar 21 17:48:14 UTC 2016

#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
----------------------------------------+----------------------------------
 Reporter:  s7r                         |          Owner:  teor
     Type:  defect                      |         Status:
 Priority:  High                        |  needs_information
Component:  Tor                         |      Milestone:  Tor:
 Severity:  Major                       |  0.2.8.x-final
 Keywords:  027-backport, 026-backport  |        Version:  Tor: 0.2.6.10
Parent ID:                              |     Resolution:
 Reviewer:                              |  Actual Points:
                                        |         Points:
                                        |        Sponsor:
----------------------------------------+----------------------------------
Changes (by teor):

 * keywords:  027-backport, 026-backport, must-fix-before-028-rc =>
     027-backport, 026-backport

Comment:

 I'd like to get this fixed before 0.2.8-rc, but it might not make it.

 Here's how I'd like to fix it:
 * put the attached sample code into two functions in tor to detect the two
 different non-standard configs;
 * when we open the ControlPort, check if either of those conditions
 applies, and close it with a warning if they do;
 * check it works on the BSD test environment from s7r;
 * merge in 0.2.8 if it's done in time;
 * refactor to use #17949 if we can in 0.2.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17901#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online