[tor-bugs] #20572 [Core Tor/Tor]: hs: Remove the private key material from hs_descriptor.h

[Tor Bug Tracker & Wiki]

#20572: hs: Remove the private key material from hs_descriptor.h
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:  jryans
     Type:  defect                              |         Status:
                                                |  needs_information
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612  |  Actual Points:
Parent ID:                                      |         Points:  0.5
 Reviewer:  dgoulet                             |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by jryans):

 * status:  needs_revision => needs_information


Comment:

 Okay, I am happy to take a look at this as well!  I have a few questions:

 1. Since `curve25519` is part of `hs_desc_intro_point_t` and the
 descriptor can have a variable number of intro points, should
 `hs_desc_encode_descriptor()` be passed a list of keypairs, one for each
 intro point?  (Would it be better to create the higher level structure for
 key material here instead of waiting for #20657?)

 2. It seems like the legacy path (using `crypto_pk_t *legacy;`) also
 contains a private key.  Should that also be cleaned up as well?

 As a meta-question, I think I would normally add a separate regular commit
 to the branch (not a fixup) for this additional work, since it feels like
 an independent task and less like correcting an error noticed during
 review.  Is that okay?  (Still trying to get a feel for the desired Tor
 patch workflow, sorry for the mechanical questions.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20572#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online