[tor-bugs] #20572 [Core Tor/Tor]: hs: Remove the private key material from hs_descriptor.h

[Tor Bug Tracker & Wiki]

#20572: hs: Remove the private key material from hs_descriptor.h
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:  jryans
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612  |  Actual Points:
Parent ID:                                      |         Points:  0.5
 Reviewer:  dgoulet                             |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Looks good!

 So I kind of fucked it up and I'm sorry about that. `curve25519_keypair_t
 curve25519` should actually be _only_ the public key
 (`curve25519_public_key_t`) :S

 Only the public key is published in the descriptor and only that public
 key is used by the client for encryption so the private key is a service
 specific key material. It shouldn't be difficult to change. What I suggest
 is that you pass a curve25519 keypair to the right function for encoding
 which means you'll have to change 3 or 4 functions signature to bring that
 keypair up to the right place. (as a fixup commit)

 With the service implementation (#20657), the
 `hs_desc_encode_descriptor()` function will probably change to take a high
 level structure for "key material" from which we'll be able to handle the
 versioning much cleaner but for now this is fine.

 Let me know if you don't have the time to do it, I'll just take it from
 your hands, no worries :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20572#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online