[tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  defect             |         Status:  needs_revision
 Priority:  Medium             |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 I'm still unclear what you refer to.  I believe we're now accepting those
 descriptors with non-ASCII country codes in extra-info descriptors that we
 rejected earlier.  What case do you have in mind where we're not accepting
 descriptors because of ASCII conversion failures?  Note that we need to
 perform some basic checks and computations to parse the descriptor
 publication time, find out the descriptor digest, etc., so that we can
 store it.  Part of the requirements are an ASCII string at the beginning
 and the end of the descriptor that tells us what part to compute the
 digest of.  If those are not ASCII, we cannot process the descriptor.  And
 if anything in between is not ASCII, we shouldn't complain, well, after
 applying this patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19170#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online