[tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  defect             |         Status:  needs_revision
 Priority:  Medium             |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 karsten]:
 > Replying to [comment:16 iwakeh]:
 > > The patch doesn't correct the extra-info descriptor part
 [https://gitweb.torproject.org/collector.git/tree/src/main/java/org/torproject/collector/relaydescs/RelayDescriptorParser.java#n272
 here and below] (afaict)?
 >
 > Hmm, I don't yet see what you mean.  The only place where we're using
 metrics-lib's `DescriptorParser` to parse a byte array is
 `ArchiveWriter#store()`.  The `haveParsed...` method called below the
 place you referenced only tells the downloader that we have parsed a
 descriptor and that it should attempt to fetch any descriptors referenced
 from it.  And the ASCII conversion above is only there to find descriptor
 start and end, though we're computing the digest on the non-converted byte
 array.  Can you give an example of a case where we're still rejecting a
 descriptor only because of metrics-lib?

 Not because of metrics-lib, but this ticket is mostly about these extra-
 info descriptors that are not stored, b/c of ascii conversion failure.
 The metrics-lib part is fine, but a different reason.
 So, only half is fixed.

 Can this be fixed for 1.0.0?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19170#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online