[tor-bugs] #8546 [Tor]: Make a copy-able connection-config type to limit copy burden of isolation flags, etc

[Tor Bug Tracker & Wiki]

#8546: Make a copy-able connection-config type to limit copy burden of isolation
flags, etc
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-client, refactoring,
Actual Points:           |  026-triaged-1, nickm-patch, andrea-review
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by nickm):

 Thanks for the review!  I'm 99% sure that the CONN_TYPE_AP_LISTENER case
 is safe. It actually copied nearly all fields before, but set just a few
 of them in the non-listener case.

 Fixing and merging to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8546#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online