[tor-bugs] #8546 [Tor]: Make a copy-able connection-config type to limit copy burden of isolation flags, etc

[Tor Bug Tracker & Wiki]

#8546: Make a copy-able connection-config type to limit copy burden of isolation
flags, etc
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-client, refactoring,
Actual Points:           |  026-triaged-1, nickm-patch, andrea-review
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by andrea):

 be8dd7f6a73d919ffdecbb95f2e7e89a49bd1c97:
  - All this looks good to me

 ff40663a8e4efd28ea99ec06d178dd8859cb5101:
  - Ditto, and I should learn coccinelle

 dbdc5c91250f15382ba3c132d60167402aa56f68:
  - This one looks fine to me too; I presume the intent is to copy this
 from
    the listener_connection_t to the new incoming connection?

 5978c2226ae6bbe3c539b86251bd7d9afe8f82dc:
  - Looks fine

 5d58a096713a8c8622d56d60b5aebd5d23616299:
  - This looks okay to me

 bb48b1d03b7d8d294f7fb7aecae6bd527b5e1a92:
  - Looks good

 73f17c32b2f0e39f06067ee61871f5dd9cdefaba:
  - Looks good to me

 cf5d435ecc9a1918b4143d9a8f6e7bcbbd2039b8:
  - Hmm, I think we're okay here, but it looks like in some cases (i.e.
    type == CONN_TYPE_AP_LISTENER) we're copying the whole structure
    instead of just a few fields in the old code.  Are we certain it won't
    ever carry along values that will cause problems?

 d669e1b51b702c62fbc3bf0f0353458af1cd86ae:
  - s/simplifification/simplification/, surely

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8546#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online