[tor-bugs] #17821 [metrics-lib]: adapt metrics-lib to actual tordnsel format

[Tor Bug Tracker & Wiki]

#17821: adapt metrics-lib to actual tordnsel format
-------------------------+--------------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  defect       |         Status:  needs_revision
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 I changed the line above, and I added a change log entry.

 However, when writing that change log entry I realized that the previous
 behavior was not a bug after all!  What we did was that we simply parsed
 an entry with multiple `"ExitAddress"` lines as separate exit list
 entries.  But okay, I think the new interface is cleaner, so let's switch.

 But!  The way that `getExitAddress()` and `getScanMillis()` are currently
 implemented introduce a new bug, because we're return fewer exit list
 entries in `getExitListEntries()` than before.  What we should do is keep
 the new behavior of `getEntries()` and change `getExitListEntries()` to
 return the old number of entries.  I don't have a good fix in mind right
 now, but if we don't fix this, we'll break existing applications.  Want to
 look into this?

 Regarding tests, I'd probably add another test for a missing `"ExitNode"`
 line and one for a missing `"Published"` line, but those should be
 sufficient.  Oh, and of course, the new behavior described in the previous
 paragraph would need testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17821#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online