[tor-bugs] #17821 [metrics-lib]: adapt metrics-lib to actual tordnsel format

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 14 13:54:54 UTC 2015


#17821: adapt metrics-lib to actual tordnsel format
-------------------------+--------------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  defect       |         Status:  needs_revision
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+--------------------------------

Comment (by iwakeh):

 Replying to [comment:8 karsten]:
 > I changed the line above, and I added a change log entry.
 Thanks!
 >
 > However, when writing that change log entry I realized that the previous
 behavior was not a bug after all!  What we did was that we simply parsed
 an entry with multiple `"ExitAddress"` lines as separate exit list
 entries.
 I think, these lines were first treated as a new exitlist-entry, but then
 discarded because the other keywords were missing.

 > But!  The way that `getExitAddress()` and `getScanMillis()` are
 currently implemented introduce a new bug, because we're return fewer exit
 list entries in `getExitListEntries()` than before.  ...
 >
 With the above reasoning the new code returns the same number as the old
 in `getExitListEntries()`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17821#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list