[tor-bugs] #13172 [Tor]: Stop using operators as macro arguments ?

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 6 17:38:16 UTC 2014


#13172: Stop using operators as macro arguments ?
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by dgoulet):

 The defines in ticket13172 are ok.

 My perl ninja is real bad so I'll let you be the judge that everything is
 indeed modified with that.

 Quick grep, I found this that has a space between the op and ",". Not sure
 the regex above covers it. Only one I found FYI, I have tested ' ,' and '
 )'.

 {{{
 ./src/ext/tinytest_demo.c +80   tt_int_op(strcmp("abc", "abcd"), < , 0);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13172#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list