[tor-bugs] #13172 [Tor]: Stop using operators as macro arguments ?

[Tor Bug Tracker & Wiki]

#13172: Stop using operators as macro arguments ?
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_review


Comment:

 branch 'ticket13172' in my public repository has a changes file and the
 necessary new macros.  After merging that, we should run this perl script
 over the code:

 {{{
 #!/usr/bin/perl -w -p -i

 next if m#^ */\*# or m#^ *\* #;

 s/<([,)])/OP_LT$1/;
 s/(?<=[\s,])<([,)])/OP_GT$1/;
 #s/>([,)])/OP_GT$1/;
 s/==([,)])/OP_EQ$1/;
 s/>=([,)])/OP_GE$1/;
 s/<=([,)])/OP_LE$1/;
 s/!=([,)])/OP_NE$1/;
 }}}

 The rigamarole about skipping obvious comments and continuations, and the
 complications on the OP_GT macro, are meant to keep us from changing HTML
 elements in doxygen comments.

 I believe that asn and dgoulet like this idea.  Does anybody object?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13172#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online