[tor-bugs] #7912 [Tor]: Cells that don't get inserted into cell queues can clog connection flushing

[Tor Bug Tracker & Wiki]

#7912: Cells that don't get inserted into cell queues can clog connection flushing
------------------------------------+---------------------------------------
 Reporter:  asn                     |          Owner:                    
     Type:  defect                  |         Status:  needs_review      
 Priority:  major                   |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                     |        Version:                    
 Keywords:  tor-relay 023-backport  |         Parent:                    
   Points:                          |   Actualpoints:                    
------------------------------------+---------------------------------------

Comment(by nickm):

 >you have circuit_set_p_circid_chan() clearing circ->p_delete_pending and
 marking the circuit ID unusable on the old channel, but
 circuit_set_n_circid_chan() *sets* circ->n_delete_pending in the analogous
 case (which is a no-op since the test for the if already implies that).
 That seems unlikely to be correct.

 Okay; will investigate and fix.

 >  we might want to consider more flexible policy than alternation.

 Agreed.

 > How thoroughly has this been tested, given the number of different bits
 of code it touches?

 Hardly at all.  I *think* I ran it on a chutney network and it didn't
 explode, but that doesn't mean much.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7912#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online