[tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 11 14:19:30 UTC 2013


#6810: Reduce code duplication across client programs
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  dcf         
     Type:  enhancement  |         Status:  needs_review
 Priority:  minor        |      Milestone:              
Component:  Flashproxy   |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by aallai):

  * status:  new => needs_review


Comment:

 I have a branch for this at https://github.com/aallai/flashproxy.git
 code_dup.

 It factors out parse_addr_spec and format_addr into a .py file and adds a
 setup.py to install the client programs. I think it pretty much replaces
 the install make target.

 Some odds and ends:

 - The setup.py is copied into the zip for the windows distribution, where
 it is useless.

 - The version is hard coded in the setup.py script. So it will need to be
 changed both in the makefile and the setup.py. Maybe the dist target could
 modify the setup script to include the correct version. I notice George
 uses something called versioneer to manage his version numbers, I'll look
 into that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list