[tor-bugs] #8308 [Tor]: Use smartlist-of-strings rather than preallocated-charbuf for more directory stuff

Tue Apr 2 15:31:57 UTC 2013

#8308: Use smartlist-of-strings rather than preallocated-charbuf for more
directory stuff
--------------------------------+-------------------------------------------
 Reporter:  nickm               |          Owner:                    
     Type:  defect              |         Status:  needs_review      
 Priority:  normal              |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                 |        Version:                    
 Keywords:  tor-auth tor-relay  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------

Comment(by nickm):

 Oops; it didn't pass unit tests. How did we all miss that? :(  Fixed in
 the branch now.

 I'm going to test it in two ways.  First, I'm going to write tests till
 every line that changed has unit test coverage. (Right now, there appear
 to be 47 without.)  Second, I'm going to do an interop test on a network
 where some nodes (including 2/4 authorities have this branch merged) and
 others do not.

 Any other tests I should do here?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8308#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online