[tor-bugs] #8308 [Tor]: Use smartlist-of-strings rather than preallocated-charbuf for more directory stuff

[Tor Bug Tracker & Wiki]

#8308: Use smartlist-of-strings rather than preallocated-charbuf for more
directory stuff
--------------------------------+-------------------------------------------
 Reporter:  nickm               |          Owner:                    
     Type:  defect              |         Status:  needs_review      
 Priority:  normal              |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                 |        Version:                    
 Keywords:  tor-auth tor-relay  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------

Comment(by nickm):

 Findings:
   * Our tests didn't cover actually making microdesc consensuses with
 microdesc lines in them. Whoops.  Wrote a test.
   * We have no test for generate_v2_networkstatus_opinion(). Right now
 that function's obsolescent, but we don't want to lose the ability to turn
 it back on in a hurry. I'll write a quick-and-dirty test.
   * We have no test for routerstatus_getinfo_helper_single. I'll write
 one.
   * Our test for dumping a routerinfo_t doesn't include a ContactInfo line
 or an ntor key or an exit policy that policy_write_item would dump, or an
 ipv6_exit_policy, it seems. I'll try adding those.
   * Our code no longer uses router_get_networkstatus_v3_hash. Removing it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8308#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online