[tor-bugs] #6864 [pyonionoo]: search shouldn't use space separated values

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Sep 24 20:13:53 UTC 2012


#6864: search shouldn't use space separated values
-----------------------+----------------------------------------------------
 Reporter:  gsathya    |          Owner:  gsathya
     Type:  defect     |         Status:  new    
 Priority:  normal     |      Milestone:         
Component:  pyonionoo  |        Version:         
 Keywords:             |         Parent:         
   Points:             |   Actualpoints:         
-----------------------+----------------------------------------------------
Changes (by karsten):

  * component:  Onionoo => pyonionoo


Comment:

 Replying to [comment:5 gsathya]:
 > Actually with Pyonionoo, the '+' is automagically converted to space by
 Cyclone, so we can continue supporting both :) I don't think it's
 necessary to support multiple parameter value option. The '+' is a more
 accurate representation since we're actually doing an intersection
 operation.

 Okay, great!  Now, that was easy. :)

 > I guess Onionoo should parse the '+'.

 Turns out this is harder, because Tomcat doesn't like the "+" character in
 parameter values.  But given that we're phasing out Onionoo's front-end
 quite soon, this doesn't matter much.  Here's what I think we should do:

  1. Deploy Pyonionoo's front-end once it provides the same functionality
 as Onionoo's front-end.
  1. Add "+"-separated search terms to the specification, while still
 supporting space-separated search terms.  Announce on the protocol page
 that space-separated searching will stop working two months later.
  1. Update Atlas (and any other Onionoo clients) to use "+"-separated
 search terms.
  1. Stop supporting space-separated search terms in Pyonionoo and update
 the protocol page to say so.

 Does that make sense?  Changing back to the pyonionoo component.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6864#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list