[tor-bugs] #6864 [Onionoo]: search shouldn't use space separated values

[Tor Bug Tracker & Wiki]

#6864: search shouldn't use space separated values
---------------------+------------------------------------------------------
 Reporter:  gsathya  |          Owner:  gsathya
     Type:  defect   |         Status:  new    
 Priority:  normal   |      Milestone:         
Component:  Onionoo  |        Version:         
 Keywords:           |         Parent:         
   Points:           |   Actualpoints:         
---------------------+------------------------------------------------------
Changes (by gsathya):

  * component:  pyonionoo => Onionoo


Comment:

 Replying to [comment:3 karsten]:
 > Replying to [comment:2 gsathya]:
 > > Spaces get encoded as a '+', Atlas and Onionoo need to be fixed to use
 that. Spaces aren't a legal part of the querystring(not safe either). I
 figured it might be better to stick to the RESTful API conventions which
 is using "multiple parameter values", but if it's going to be a pain to
 change, then we should at least use url encoded spaces.
 >
 > We can do either '+' or multiple parameter values.  I'm fine with
 either.  If you say multiple parameter values conform more to the RESTful
 API conventions, let's do that.  (Do you have a link stating that?)
 >
 > Oh, this just comes to mind: it may be that we didn't use '+', because
 Tomcat didn't support it for some reason.  That limitation will go away
 once we switch to Pyonionoo.  Tomcat does support multiple parameter
 values, though.
 >
 > We just need to keep supporting the current space-separated values for
 another two or three months in parallel to that, or we'll break existing
 applications without prior notice.

 Actually with Pyonionoo, the '+' is automagically converted to space by
 Cyclone, so we can continue supporting both :) I don't think it's
 necessary to support multiple parameter value option. The '+' is a more
 accurate representation since we're actually doing an intersection
 operation.

 I guess Onionoo should parse the '+'.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6864#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online