[tor-bugs] #5454 [Stem]: ExitPolicy Class for stem

[Tor Bug Tracker & Wiki]

#5454: ExitPolicy Class for stem
-------------------------+--------------------------------------------------
 Reporter:  gsathya      |          Owner:  atagar      
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Stem         |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by gsathya):

  * status:  needs_revision => needs_review


Comment:

 Thanks a lot for the code review!

 https://gitweb.torproject.org/user/gsathya/stem.git/commit/3bbb6cb193447f3c07129d0c1b96ebaad3db8a25

 >   - Arm used camel case variables (myVar) and stem uses the more
 official, pythony underscores (my_var).

 Fixed

 >   - Pydocs in stem have a very specific, standardized format - see any
 of the other files for examples. They also have header pydocs.

 Fixed to an extent - Needs a little more work.

 >   - Everything else in stem has the indentation of two spaces. This one
 has four.

 Fixed. Sorry, OONI uses 4 and I got a little confused.

 > - Something to think about is how we want to handle descriptor exit
 policies verses microdescriptor exit policies. Arm had code for handling
 them as an ExitPolicy but they lack some information (no ip addresses or
 private keyword) so I'm not sure if that's the best solution.

 I'm not sure of the difference - I'll read up on the microdescriptor exit
 policies, but it looks like we can subclass ExitPolicyLine for the
 microdescriptor exit policies?

 > - We don't need integration tests for this (descriptor and consensus
 integ tests will cover it), but this module does need a lot of unit
 testing to cover all the weird use cases that will commonly trip it up. To
 start with though we need some basic smoke tests to start exercising this
 code.

 I'll start on the unit test soon.

 (Also, I'm currently adding the get_summary() method to ExitPolicy. )

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5454#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online