[tor-bugs] #5454 [Stem]: ExitPolicy Class for stem

[Tor Bug Tracker & Wiki]

#5454: ExitPolicy Class for stem
-------------------------+--------------------------------------------------
 Reporter:  gsathya      |          Owner:  atagar        
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_revision


Comment:

 Thanks for getting this started. I agree that we should have an ExitPolicy
 class that contains the list of entries. Some things from the first
 pass...

 - Part of porting things from arm to stem is to fix the conventions. A few
 changes are...
   - Arm used camel case variables (myVar) and stem uses the more official,
 pythony underscores (my_var).
   - Pydocs in stem have a very specific, standardized format - see any of
 the other files for examples. They also have header pydocs.
   - Everything else in stem has the indentation of two spaces. This one
 has four.

 - Something to think about is how we want to handle descriptor exit
 policies verses microdescriptor exit policies. Arm had code for handling
 them as an ExitPolicy but they lack some information (no ip addresses or
 private keyword) so I'm not sure if that's the best solution.

 - We don't need integration tests for this (descriptor and consensus integ
 tests will cover it), but this module does need a lot of unit testing to
 cover all the weird use cases that will commonly trip it up. To start with
 though we need some basic smoke tests to start exercising this code.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5454#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online