[tor-bugs] #6153 [Tor Client]: Make circ_times static, and abstract most of its accessors.

[Tor Bug Tracker & Wiki]

#6153: Make circ_times static, and abstract most of its accessors.
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  minor       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  cbt         |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 The circ_times structure is exported as a global from circuitbuild.c.  It
 really shouldn't be.  It has 3 kinds of external users FWICT:

  * Things that pass it as an argument to circuit_build_*().
  * Two functions in circuituse.c that want to know the current timeout
 values.

 For the former we could use an accessor function, or we could have the
 functions in circuitbuild.c use the static object if they receive NULL.
 For the latter, we could have a function that returns the current
 timeouts.

 Making this change would also let us more completely avoid looking at
 circ_times when LearnCircuitBuildTimeout is 0.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6153>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online