[tor-bugs] #5049 [Tor Client]: When LearnCircuitBuildTimeout is off, we should ignore (most?)( CBT parameters from the consensus

[Tor Bug Tracker & Wiki]

#5049: When LearnCircuitBuildTimeout is off, we should ignore (most?)( CBT
parameters from the consensus
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Replying to [comment:7 andrea]:
 > As for the circ_times vs. function to get timeouts, I like the idea of
 abstracting the timeout query in a function, but LearnCBT == 0 isn't the
 only circumstance we want to disable this code in.  It's also possible to
 get a cbtdisabled consensus parameter.  If we do that, we'd want the
 function to call circuit_build_times_disabled() like everything else does
 rather than check LearnCBT directly.

 Agreed.  I'll squash what you have a bit, rebase, merge, and then open a
 new ticket for "abstract accesses to circ_times".

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5049#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online