[tor-bugs] #6507 [Tor Client]: Explicit "ORPort 0" should still trigger client mode

[Tor Bug Tracker & Wiki]

#6507: Explicit "ORPort 0" should still trigger client mode
------------------------+---------------------------------------------------
 Reporter:  zwol        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:  Tor: 0.2.3.19-rc  
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Hm. On the other hand, parse_port_config uses "FooPort 0" to mean "Ignore
 the default setting for the port if there is one."  So revising the
 parsing code so that SocksPort 0 was the same as providing no SOCKSPort
 would be broken.  That means that the first option isn't so great.

 And on the other hand, scanning the options to see whether an ORPort is
 set or not probably requires actually parsing them, to so that NoListen
 addresses don't get counted.  That means that the second option isn't as
 easy as replacing all the options->FooPort with a new function call.

 More thought needed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6507#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online