[tor-bugs] #6507 [Tor Client]: Explicit "ORPort 0" should still trigger client mode

[Tor Bug Tracker & Wiki]

#6507: Explicit "ORPort 0" should still trigger client mode
------------------------+---------------------------------------------------
 Reporter:  zwol        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:  Tor: 0.2.3.19-rc  
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * milestone:  => Tor: 0.2.3.x-final


Comment:

 ug. Looks like there are still a few checks "options->ORPort" as a
 boolean.

 Two options:
   * Revise the parsing code, so that 'FooPort 0' clears out the FooPort
 options,
     and makes option->FooPort become NULL.
   * Revise everything that looks at (options->FooPort) as a boolean.

 It looks like there are still 5 boolean checks for ORPort, 12 boolean
 checks for DirPort, 2 for TransPort, and 1 for ControlPort.  That makes 19
 places in the code to fix altogether if we take the second approach.  I'm
 thinking that the first might make more sense.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6507#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online