[tor-bugs] #4125 [Tor Relay]: Implement proposal 176 (renegotiation-free handshake)

[Tor Bug Tracker & Wiki]

#4125: Implement proposal 176 (renegotiation-free handshake)
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:  nickm              
     Type:  enhancement  |         Status:  needs_review       
 Priority:  normal       |      Milestone:  Deliverable-Nov2011
Component:  Tor Relay    |        Version:                     
 Keywords:               |         Parent:                     
   Points:               |   Actualpoints:                     
-------------------------+--------------------------------------------------

Comment(by asn):

 * If `command_process_cert_cell` receives a CERT cell, with two
 OR_CERT_TYPE_TLS_LINK certificates it will decode, ignore and *not* free
 the second one, because of:
 {{{
         if (cert_type == OR_CERT_TYPE_TLS_LINK && !link_cert)
           link_cert = cert;
         ...
         else
           tor_cert_free(cert);
 }}}

 The same goes for the other types of allowed certificates.

 * In command_process_auth_challenge_cell() don't forget to use ERR() or
 return in:
 {{{
     if (connection_or_send_authenticate_cell(conn, use_type) < 0) {
       /* XXX log */
       connection_mark_for_close(TO_CONN(conn));
     }
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4125#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online