[tor-bugs] #4094 [Tor Client]: "TestSocks 1" and IP addresses in requests using "safe" socks protocols result in misleading log messages

[Tor Bug Tracker & Wiki]

#4094: "TestSocks 1" and IP addresses in requests using "safe" socks protocols
result in misleading log messages
------------------------+---------------------------------------------------
 Reporter:  fk          |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  minor       |      Milestone:                    
Component:  Tor Client  |        Version:  Tor: 0.2.3.4-alpha
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by fk):

  * status:  new => needs_review


Comment:

 I didn't consider the various ways an IP address can be
 expressed.

 Actually verifying that a hostname has been given may not
 be worth it, especially given that the user can already let
 Tor additionally log the destination address used by the client
 by temporarily disabling SafeLogging.

 The attached patch thus only rewords the messages as suggested.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4094#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online