[tor-bugs] #3814 [Tor Relay]: Duplicate mark_for_close when running server with bufferevents

[Tor Bug Tracker & Wiki]

#3814: Duplicate mark_for_close when running server with bufferevents
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:  #3561             
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Yes; this is almost certainly causing lossage in linked connections.  The
 issue is that writing to a paired bufferevent can cause the data to get
 transferred immediately, so that checking right after to see if anything
 is sitting on the buffer won't actually do you any good.

 I think we can fix this one by checking dir_spool_src in
 connection_dir_finished_flushing().  See branch bug3814 in my public
 repository.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3814#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online